Subsystem 6d: Smelting calculator (/smelt + in-game, schema v4) - #31
Merged
Conversation
…form) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… floor) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…DRY) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subsystem 6d — Item Database Calculators pt.4 (Smelting)
Fourth slice of the Item Database subsystem, a faithful mirror of 6a/6b/6c (#28/#29/#30). Ships a smelter-keyed smelting calculator: in-game
!smelt <smelter>and Discord/smelt <smelter>list every conversion a smelter performs (input → output, quantity/probability, wood/fuel, time).Approach
Smelting data is natively keyed by smelter and the same input name appears under different item ids across smelters, so it does not hang off
ItemRecord— it gets its own top-levelSmelterstable resolved by name, exactly like 6c'sRaidTargets. NoKindenum (all 10 smelters are items). Sourced offline fromrustlabsSmeltingData.json(28.5 KB, 10 smelters),SmeltingAsOf = 2023-11-05.What's in it
Smelter/SmeltConversionrecords +Smelterstable;DatasetSources.SmeltingAsOf.ISmeltingSource/OfflineSmeltingSource(per-smelter projection, orphan-drop),DatasetValidatorsmelter checks (MinSmelterCount: 8floor + per-conversion validation), regenerated embeddeditem-data.json.SmeltMatch/SmeltLookup+IItemDatabase.ResolveSmelter(mirrors RaidLookup/RaidMatch).DurationFormat.Seconds(double)(sub-minute aware) used by a refactoredDurabilityLineand the newSmeltLine.SmeltCommandHandler(!smelt) +/smeltslash (RespondForSmeltAsync),/helprows, EN/FR resx keys.Tests & gates
Full TDD throughout. Suite 666 tests / 16 assemblies green; build
-warnaserror0 warnings;jb cleanupcodeclean.Deferred
Input-keyed "where can I smelt X" view, slot-count/throughput math, and CCTV (the last open subsystem-6 item).
🤖 Generated with Claude Code